test: avoid flaky restart sync in debugger exceptions test#62055
Open
inoway46 wants to merge 2 commits intonodejs:mainfrom
Open
test: avoid flaky restart sync in debugger exceptions test#62055inoway46 wants to merge 2 commits intonodejs:mainfrom
inoway46 wants to merge 2 commits intonodejs:mainfrom
Conversation
nodejs-github-bot
added
needs-ci
inoway46
force-pushed
the
fix-flaky-test-debugger-exceptions
branch
from
217a40b to
bfe5f1b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62055 +/- ##
==========================================
- Coverage 89.69% 89.68% -0.01%
==========================================
Files 706 706
Lines 218222 218222
Branches 41768 41771 +3
==========================================
- Hits 195731 195711 -20
- Misses 14411 14418 +7
- Partials 8080 8093 +13 🚀 New features to boost your workflow:
|
lpinca
approved these changes
Mar 25, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
inoway46
force-pushed
the
fix-flaky-test-debugger-exceptions
branch
2 times, most recently
from
64b5b0e to
a3aa5ce
Compare
jasnell
approved these changes
Mar 28, 2026
cola119
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Contributor
Author
|
Since the Windows flakiness seems better now, could you please rerun CI for this PR? |
Collaborator
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
https://ci.nodejs.org/job/node-test-commit-windows-fanned/76495/console I'm not sure this will help, but rebasing this branch onto the latest |
StefanStojanovic
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
inoway46
force-pushed
the
fix-flaky-test-debugger-exceptions
branch
2 times, most recently
from
c5ad00e to
27e3713
Compare
inoway46
force-pushed
the
fix-flaky-test-debugger-exceptions
branch
from
27e3713 to
1b3d3fe
Compare
Contributor
Author
lpinca
approved these changes
Apr 19, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Contributor
Author
|
#62055 (comment) |
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
test/parallel/test-debugger-exceptions.js, usingstepCommand('r')can intermittently time out while waiting forBREAK_MESSAGE. This PR preserves the test intent, but changes the reconnect sync point for r to wait forokbeforewaitForInitialBreak().Same approach as #62807
CI logs
Testing
./tools/test.py -p actions parallel/test-debugger-exceptions./tools/test.py -p actions -j1 --repeat 40 parallel/test-debugger-exceptions./tools/test.py -p actions parallel/test-debugger-restart-message parallel/test-debugger-run-after-quit-restartRefs: #61762